Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CInterface files and documentation #2947

Merged
merged 2 commits into from
May 24, 2022
Merged

Add CInterface files and documentation #2947

merged 2 commits into from
May 24, 2022

Conversation

corporateshark
Copy link
Contributor

@corporateshark corporateshark commented May 21, 2022 •
edited
Loading

Both glslang/CInterface and SPIRV/CInterface files are missing from Android.mk.

Added missing documentation.

@corporateshark corporateshark changed the title Add CInterface files Add CInterface files and documentation May 21, 2022
@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label May 23, 2022
@greg-lunarg greg-lunarg self-requested a review May 23, 2022 17:05
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label May 23, 2022
@greg-lunarg
Copy link
Contributor

Looks like you need to add StandAlone/ResourceLimits.h as well?

@corporateshark
Copy link
Contributor Author

@greg-lunarg I removed changes to BUILD.bazel from this PR to make it more focused.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label May 24, 2022
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label May 24, 2022
greg-lunarg
greg-lunarg approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@greg-lunarg greg-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the code and documentation!

@greg-lunarg greg-lunarg merged commit 604904f into KhronosGroup:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-lunarg greg-lunarg greg-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corporateshark @greg-lunarg @kokoro-team