Add support for KHR_materials_dispersion #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexaknyazev
requested changes
May 31, 2024
test/ext/KHR_materials_dispersion/khr_materials_dispersion_test.dart
Outdated
Show resolved
Hide resolved
lib/src/ext/KHR_materials_dispersion/khr_materials_dispersion.dart
Outdated
Show resolved
Hide resolved
lexaknyazev
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support and unit tests for KHR_materials_dispersion. The new files here are based on existing source and tests for IOR and Volume.
There's one new issue, a warning for when dispersion is used in the absence of volume.