Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Update/add source models (Avocado, BarramundiFish, BoomBox, Corset, and Lantern) #64

Merged
merged 7 commits into from
May 18, 2017

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented May 15, 2017

#51

@emackey
Copy link
Member

emackey commented May 15, 2017

sourceModels/Lantern/T_LanternPole_mr.png looks odd to me. Is it a metal/rough map? There's not supposed to be an alpha channel in that map is there?

@bghgary
Copy link
Contributor Author

bghgary commented May 15, 2017

That's a metallic smoothness texture intended for Unity3D which uses a sRGB grayscale metallic in RGB and a linear smoothness in A.

@emackey
Copy link
Member

emackey commented May 15, 2017

Oh, Unity, right. Thanks.

@lexaknyazev
Copy link
Member

lexaknyazev commented May 15, 2017

Please update glTF versions of Avocado and BarramundiFish in this PR. These models in master (ef49777) were produced by collada2gltf from now removed .daes.

@pjcozzi
Copy link
Member

pjcozzi commented May 17, 2017

@bghgary please squash commits before merging to keep the repo size down.

@bghgary
Copy link
Contributor Author

bghgary commented May 17, 2017

@pjcozzi will do.

Update screenshots
Update README.md files
@bghgary
Copy link
Contributor Author

bghgary commented May 17, 2017

@lexaknyazev I've updated the models.

@pjcozzi I was thinking whoever does the merge will squash the changes using GitHub. Is that good enough or did you mean something else?

@pjcozzi
Copy link
Member

pjcozzi commented May 17, 2017

@pjcozzi I was thinking whoever does the merge will squash the changes using GitHub. Is that good enough or did you mean something else?

Ah yes, I forgot about that feature!

@lexaknyazev please merge if you are happy with 2fb870b.

@lexaknyazev lexaknyazev merged commit f180050 into KhronosGroup:master May 18, 2017
@bghgary bghgary deleted the model_updates branch May 18, 2017 15:58
@emackey emackey mentioned this pull request Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants