Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Add flight helmet model #154

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Add flight helmet model #154

merged 2 commits into from
Mar 15, 2018

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Mar 15, 2018

This is a high quality model from our tech artist @PatrickRyanMS. It is modeled after a real flight helmet and showcases what you can do with the core spec using PBR metallic roughness workflow.

@emackey
Copy link
Member

emackey commented Mar 15, 2018

This looks great!

Should we add a glTF-Binary flavor of this? Lately it seems like GLB is the most important flavor of glTF to support.

@bghgary
Copy link
Contributor Author

bghgary commented Mar 15, 2018

I didn't do this because of size. This asset is over 50MB and is by far the largest asset in the repo. Each flavor multiplies against this base size. There are also plenty of tools now that convert from glTF to GLB. Thoughts?

@emackey
Copy link
Member

emackey commented Mar 15, 2018

Hmm, OK. SciFiHelmet also lacks a binary version, I guess we can have some models without it.

@emackey emackey merged commit bcef0fb into KhronosGroup:master Mar 15, 2018
@cx20
Copy link
Contributor

cx20 commented Mar 16, 2018

I tried this model with gltf-test.

The point I thought of as issue is as follows.

  • The goggles of minimal-glTF-Loader are opaque.
  • The goggles of PlayCanvas are opaque.
  • The goggles of x3dom are transparent, but the contents displayed are different from other libraries.

Please tell me if there are other display parts different from the assumed one. I will report the issue to each library later.

The following is the execution result for each library. Khronos glTF Loader is excluded because Too many texture error appeared and it could not be displayed.

image image image
image image image
image image image
image

@lexaknyazev
Copy link
Member

@cx20 Please fix Cesium link, it shows DamagedHelmet.

@cx20
Copy link
Contributor

cx20 commented Mar 16, 2018

@lexaknyazev Oops! I was linking to a different helmet. I fixed the link now.

@bghgary bghgary deleted the flight-helmet branch March 16, 2018 16:11
@cx20
Copy link
Contributor

cx20 commented Mar 17, 2018

I confirmed that the problem of goggles has been resolved by using the latest version library of PlayCanvas and x3dom.

Three.js PlayCanvas x3dom
image image image

@donmccurdy
Copy link
Contributor

Looks outstanding!

By the way, this helmet model contains a TEXCOORD_1 attribute that appears to be unused.

@bghgary
Copy link
Contributor Author

bghgary commented Mar 30, 2018

By the way, this helmet model contains a TEXCOORD_1 attribute that appears to be unused.

Yeah, I noticed this earlier too. I'm not sure where it's coming from since the source asset doesn't have it. I'll find out.

@bghgary
Copy link
Contributor Author

bghgary commented Mar 31, 2018

Should be fixed with #159

@andrewvarga
Copy link

Would it be possible to use the same environment to see a more consistent comparison between engines?

@cx20
Copy link
Contributor

cx20 commented Apr 10, 2018

@andrewvarga If you would like to compare glTF models, I think that @vorg's pbr-compare will be helpful than my gltf-test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants