Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Add new model WalkingLady #12

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

emadurandal
Copy link

@emadurandal emadurandal commented Dec 4, 2016

Hi, everyone.

I have been promoting glTF support with my WebGL library GLBoost.
I created my skinning animation model myself using Maya and tried playing it.

This time, pull requesting this model is for some interesting reasons.

Of course, the GLBoost library plays this model correctly. However, all other well-known WebGL libraries fail to play.

Is this model something special? No, JglTF seems to be able to play this model properly.

For this reason, I think that there are still some problems in implementations of skinning animation in each WebGL library.
This model may be a good touchstone in trying the compatibility of glTF skinning animation of each library.

If there is no problem, I am glad if you adopt it.

Related Issues

KhronosGroup/glTF#685
javagl/JglTF#2

@emadurandal
Copy link
Author

FYI,

My friend cx20 has updated the comparison page.
You can access WalkingLady example of each library from here.
https://github.com/cx20/gltf-test

@pjcozzi
Copy link
Member

pjcozzi commented Dec 6, 2016

Thanks for the sample model! It would be good for one more library (e.g., CesiumGS/cesium#4722) to confirm that this model is valid before we merge this.

You could also try the glTF Validator but that is for glTF 1.1 so it may report a few warnings/errors that do not apply to 1.0.

@emadurandal
Copy link
Author

@pjcozzi Thank you! I'll check the glTF Validator.

And breaking news. My friend @kyasbal-1994 (a talented university student)'s WebGL library Grimoire.js (https://grimoire.gl) has supported this animation model Just before.
https://i.gyazo.com/7b94744dc07f069f47d83cf9ca2da904.mp4
(I am surprised that he has overtaken the glTF support level I have built over half a year, in just one month from the start of work!)

After preparation, GrimoireJS's version of the example will be opened at @cx20's loader comparison page.

@kyasbal
Copy link

kyasbal commented Dec 7, 2016

@emadurandal Thanks for introducing my library.

I need to note that I supported glTF feature as an extension and it is still under beta.( there are performance problems and some of material bugs yet)
And I'm sorry but my library only have webpage written in Japanese yet.(Github page https://github.com/GrimoireGL/GrimoireJS is only the page written in English but a little bit old) I would prepare web pages written in English as soon as possible.

@pjcozzi
Copy link
Member

pjcozzi commented Dec 8, 2016

@kyasbal-1994 could you please open a pull request in the glTF repo to add your engine to the list of tools supporting glTF?

@pjcozzi
Copy link
Member

pjcozzi commented Dec 8, 2016

@kyasbal-1994 also your engine looks great! We would welcome any other contributions you are able to make to the glTF community, for example, see KhronosGroup/glTF#456

@emadurandal
Copy link
Author

@kyasbal-1994 congrats!

BTW, It seems that three.js has supported this animation model.
mrdoob/three.js#10319

I made this glTF data using Maya's OpenCollada Plugin & COLLADA2GLTF Converter.
So, to establish glTF workflow in Maya, being able to play this model may be one requirement for now.

@pjcozzi
Copy link
Member

pjcozzi commented Dec 14, 2016

OK, sounds like it is not an issue with the model, thanks again for the contribution!

@pjcozzi pjcozzi merged commit c9597ea into KhronosGroup:master Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants