-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a mechanism for adding new extensions #593
Conversation
KHR_materials_unlit and KHR_lights_punctual have been implemented succesfuly using this mechanism |
45e65fc
to
b9503f7
Compare
@donmccurdy @julienduroure could you please have a look at this? |
Activity is quite low during the summer, but I will definitively have a look on it when I can |
Let's try to plan it for blender 2.82, it's too late for 2.81 |
efc4757
to
03664e0
Compare
@julienduroure CI is failing in some tests that have nothing to do with my changes. |
@jjcasmar CI is successful on current master, so your changes are probably the root cause of the failing. Run 0:
Maybe a merge issue ? Run 1:
Maybe a merge issue, but is about extension data Run 2 :
Definitively an issue in your code Run 3:
Definitively an issue in your code |
8d7860b
to
a99e313
Compare
Moved to #732 |
The exporter now looks for user defined extensions and call them when necesary. This way, its easy to implement new user defined extensions without the need to fork the exporter.