Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mechanism for adding new extensions #593

Closed
wants to merge 0 commits into from

Conversation

jjcasmar
Copy link
Contributor

The exporter now looks for user defined extensions and call them when necesary. This way, its easy to implement new user defined extensions without the need to fork the exporter.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2019

CLA assistant check
All committers have signed the CLA.

@jjcasmar
Copy link
Contributor Author

KHR_materials_unlit and KHR_lights_punctual have been implemented succesfuly using this mechanism

@jjcasmar jjcasmar force-pushed the UExtensions branch 4 times, most recently from 45e65fc to b9503f7 Compare July 22, 2019 11:15
@jjcasmar
Copy link
Contributor Author

@donmccurdy @julienduroure could you please have a look at this?

@julienduroure
Copy link
Collaborator

Activity is quite low during the summer, but I will definitively have a look on it when I can

@julienduroure julienduroure added this to the Blender 2.82 milestone Sep 26, 2019
@julienduroure
Copy link
Collaborator

Let's try to plan it for blender 2.82, it's too late for 2.81
Can you please update the PR against master?

@julienduroure julienduroure added enhancement New feature or request exporter This involves or affects the export process labels Oct 2, 2019
@jjcasmar jjcasmar force-pushed the UExtensions branch 3 times, most recently from efc4757 to 03664e0 Compare October 11, 2019 20:34
@jjcasmar
Copy link
Contributor Author

@julienduroure CI is failing in some tests that have nothing to do with my changes.

@julienduroure
Copy link
Collaborator

@jjcasmar CI is successful on current master, so your changes are probably the root cause of the failing.
Are you sure that your master merge was successful too?

Run 0:

AttributeError: 'PointLamp' object has no attribute 'use_custom_distance'

Maybe a merge issue ?

Run 1:

/extensions/KHR_lights_punctual/lights/2/spot/outerConeAngle - outerConeAngle (0.0872664600610733) is less than or equal to innerConeAngle (0.0872664600610733). (KHR_LIGHTS_PUNCTUAL_LIGHT_SPOT_ANGLES))

Maybe a merge issue, but is about extension data

Run 2 :

extensions["KHR_texture_transform"] = Extension("KHR_texture_transform", texture_transform)

TypeError: 'NoneType' object does not support item assignment

Definitively an issue in your code

Run 3:

extensions["KHR_texture_transform"] = Extension("KHR_texture_transform", texture_transform)
TypeError: 'NoneType' object does not support item assignment

Definitively an issue in your code

@jjcasmar jjcasmar force-pushed the UExtensions branch 3 times, most recently from 8d7860b to a99e313 Compare October 14, 2019 22:00
@jjcasmar jjcasmar closed this Oct 14, 2019
@emackey
Copy link
Member

emackey commented Oct 16, 2019

Moved to #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter This involves or affects the export process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants