Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pipeline state queries for certain stages return a warning if the stage is disabled? #476

Closed
alexander-a-kharlamov opened this issue Nov 9, 2018 · 1 comment
Closed

Should pipeline state queries for certain stages return a warning if the stage is disabled? #476

alexander-a-kharlamov opened this issue Nov 9, 2018 · 1 comment
Milestone
sdk-1.1.97.0

Comments

@alexander-a-kharlamov
Copy link

It's unclear from the spec if querying VK_QUERY_PIPELINE_STATISTIC_GEOMETRY_SHADER_* or VK_QUERY_PIPELINE_STATISTIC_TESSELLATION_* bits in a pipeline query is illegal when VkPhysicalDeviceFeatures.geometryShader or VkPhysicalDeviceFeatures.tessellationShader respectively are disabled.

If it's legal, I think it would still be beneficial to see a warning from validation layers. If it's illegal it should be reported as an error.
@karl-lunarg karl-lunarg mentioned this issue Nov 29, 2018
Closed
@jzulauf-lunarg
Copy link
Contributor

jzulauf-lunarg commented Nov 29, 2018 •
edited
Loading

This appears to be fully legal... adding to #24 Best Practices/Assistant/Performance Layer and closing wontfix (at least not directly)

@shannon-lunarg shannon-lunarg added this to the sdk-1.1.temp.0 milestone Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sdk-1.1.97.0
Development

No branches or pull requests
3 participants
@alexander-a-kharlamov @shannon-lunarg @jzulauf-lunarg