Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation fails incorrectly for DeviceCreate with unsupported features #335

Closed
gnl21 opened this issue Sep 19, 2018 · 1 comment
Closed

Validation fails incorrectly for DeviceCreate with unsupported features #335

gnl21 opened this issue Sep 19, 2018 · 1 comment
Milestone
sdk-1.1.85.0

Comments

@gnl21
Copy link
Contributor

gnl21 commented Sep 19, 2018

Trying to create a vkDevice using unsupported features is valid (if not very useful) usage, but it currently fails validation. This is triggering a significant number of validation failures when running the CTS.
@daveh-lunarg
Copy link
Contributor

Agreed. The spec says that the driver will reply with VK_ERROR_FEATURE_NOT_PRESENT in this case, and there's no need for the validation layer to also complain. PR shortly.

@daveh-lunarg daveh-lunarg mentioned this issue Sep 19, 2018
Merged
@shannon-lunarg shannon-lunarg added this to the sdk-1.1.temp.0 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sdk-1.1.85.0
Development

No branches or pull requests
3 participants
@gnl21 @daveh-lunarg @shannon-lunarg