Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core validation: No support for vkAcquireNextImage2KHR() #315

Closed
DominikWitczakAMD opened this issue Sep 7, 2018 · 4 comments
Closed

Core validation: No support for vkAcquireNextImage2KHR() #315

DominikWitczakAMD opened this issue Sep 7, 2018 · 4 comments
Assignees
Labels
Incomplete Missing Validation VUs to be added
Milestone

Comments

@DominikWitczakAMD
Copy link
Contributor

Core validation layer does not intercept vkAcquireNextImage2KHR() calls. Amongst other uses, these are fundamental for AFR rendering.

In the use case I'm seeing, this leads to invalid errors being reported when doing the following:

  1. Let D be a logical device built of phys devices P0 and P1.
  2. Acquire a swapchain image for physical device P1. Specify a sem S to be set upon acquisition.
  3. Do a dummy cmd buffer submission with wait sem set to S.

At step 2 I'm seeing the layer report a problem with S not being set which is not true.

@tobine tobine added the Incomplete Missing Validation VUs to be added label Sep 11, 2018
@tobine tobine added this to the P2 milestone Sep 11, 2018
@tobine
Copy link
Contributor

tobine commented Sep 13, 2018

@chrisforbes added support matching vkAcquireNextImage and noted some follow-on work in comments:

  • Merge Pre/Post code between vkAquireNextImage & vkAcquireNextImage2KHR
  • Add custom VUID depending on code path

@tobine
Copy link
Contributor

tobine commented Sep 13, 2018

Also need a test for vkAcquireNextImage2KHR

@DominikWitczakAMD
Copy link
Contributor Author

Thanks for the swift turn-over. I'll verify the newly added support works as expected when I get back to the office from the f2f on Monday next week.

@mark-lunarg
Copy link
Contributor

Basic support has been added, and there are least some devicemask tests for AcuireNextImage2KHR.

@shannon-lunarg shannon-lunarg modified the milestones: P2, sdk-1.1.114.0 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete Missing Validation VUs to be added
Projects
None yet
Development

No branches or pull requests

4 participants