Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation should warn against empty acceleration structures #2081

Closed
Tobski opened this issue Jul 30, 2020 · 1 comment
Closed

Validation should warn against empty acceleration structures #2081

Tobski opened this issue Jul 30, 2020 · 1 comment
Milestone

Comments

@Tobski
Copy link
Contributor

Tobski commented Jul 30, 2020

As per KhronosGroup/Vulkan-Docs#1328, there are a number of ways to create empty acceleration structures which can't be hit in the ray tracing extension. In some cases these are going to crop up occasionally and should be completely innocuous, but there's certainly also danger that application developers didn't intend it. Adding warnings to these cases would aid in developer bring up with the ray tracing extensions.

Specifically, the cases that matter are: VkAccelerationStructureBuildGeometryInfoKHR::geometryCount is 0, VkAccelerationStructureBuildOffsetInfoKHR::primitiveCount is 0, and cases where all primitives are inactive (see spec for how triangles are determined as active or otherwise - but this is a harder to detect case which is also likely rarer).

cc @dgkoch

@mark-lunarg
Copy link
Contributor

Added to the best-practices tracking issue, #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants