Descriptor type validation doesn't handle OpGroupDecorate

[karl-lunarg]

Issue by phaulos (MIGRATED)
Thursday Mar 09, 2017 at 22:22 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#1549

---

dEQP-VK.spirv_assembly.instruction.compute.decoration_group.all is failing with:

ERROR: Type mismatch on descriptor slot 0.0 (used as type `ptr to uniform struct of (oddtype)`) but descriptor of type VK_DESCRIPTOR_TYPE_STORAGE_BUFFER (code 0x0000000d from SC at Unknown:2631)
...

Looking at the SPIR-V BufferBlock decoration is applied to 0.0 through OpGroupDecorate. This is not something glslang does so it might be that validation simply doesn't handle it.

[karl-lunarg]

Comment by chrisforbes (MIGRATED)
Friday Mar 10, 2017 at 03:58 GMT

---

Indeed, SC has no idea about group decorations at all. This is going to take a bit of work.

[karl-lunarg]

Comment by chrisforbes (MIGRATED)
Friday Mar 24, 2017 at 04:53 GMT

---

Working out with spirv-tools side how best to deal with this.

[karl-lunarg]

Comment by gwihlidal (MIGRATED)
Wednesday May 17, 2017 at 00:10 GMT

---

Any update on this? We're hitting this error in many of our shaders.

[karl-lunarg]

Comment by mark-lunarg (MIGRATED)
Thursday Mar 01, 2018 at 21:40 GMT

---

@chrisforbes, any update? Still applicable?

[mark-lunarg]

@chrisforbes, is this still an issue?

[chrisforbes]

Yes, still needed.