Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with MinGW-w64 #19

Closed
karl-lunarg opened this issue May 14, 2018 · 3 comments
Closed

Allow building with MinGW-w64 #19

karl-lunarg opened this issue May 14, 2018 · 3 comments
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@karl-lunarg
Copy link
Contributor

Issue by DragoonX6 (MIGRATED)
Thursday Mar 09, 2017 at 19:36 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#1544


I've been looking around a bit on the internet and I saw that there is no MinGW-w64 build of the Vulkan SDK. People have been suggesting using tools like dlltool to generate import libraries so you can at least link to it.

As this is far from optimal and stops people from doing source level debugging, I've been trying to get it to build with MSYS2's MinGW-w64 clang build.
This was relatively painless, however I did encounter a few minor issues, which I'll go into more detail below.
I did not check out the master branch, but the latest SDK tag, so I have no idea if master will be easier or harder to get working.

Most of the issues I encountered were missing casts for C++ compilers and some naive #ifdefs.
My current efforts have been slightly hacky, I've just been trying to get it to build, but I could submit it as a reference PR if you like.
Otherwise I could put in more effort to make a proper PR, as I haven't been building the tests either.
The tests don't build because Vulkan is shipping its own gtest and as far as I know MSYS2's gtest has been patched to work with MinGW-w64.

@karl-lunarg karl-lunarg added this to the P2 milestone May 14, 2018
@karl-lunarg
Copy link
Contributor Author

Comment by karl-lunarg (MIGRATED)
Friday Mar 10, 2017 at 14:27 GMT


Note that we build this repo with clang in the Travis CI. So the repo should be pretty close to building with some other clang.

Yes, please submit the changes in whatever form you'd like. A "proper" PR would be easier for us to deal with, but if there are not too many changes, any form will do. If we can apply the changes to help out MinGW-w64 clang builds without breaking anything else, we'll be glad to make those changes. But at this time, we're not planning on building or testing in this environment ourselves.

@karl-lunarg karl-lunarg added the Enhancement New feature or request label May 14, 2018
@karl-lunarg
Copy link
Contributor Author

Comment by karl-lunarg (MIGRATED)
Tuesday Mar 28, 2017 at 19:34 GMT


@DragoonX6 : Did PR 767 on glslang resolve your issue with building this repo? It is easy to imagine that would be the case, since running the update_external_sources script builds glslang.

Please close this issue if the glslang fix solves your problem here. Else, please let us know if anything else needs fixing.

Never mind - I found the PR.

@karl-lunarg
Copy link
Contributor Author

Comment by DragoonX6 (MIGRATED)
Sunday Jul 09, 2017 at 20:31 GMT


@karl-lunarg Updated it with a new PR #1923. Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants