Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if vkAcquireNextImageKHR too many images #1389

Closed
krOoze opened this issue Nov 20, 2019 · 4 comments
Closed

Warn if vkAcquireNextImageKHR too many images #1389

krOoze opened this issue Nov 20, 2019 · 4 comments
Milestone

Comments

@krOoze
Copy link
Contributor

krOoze commented Nov 20, 2019

Warn on attempt to acquire too many images via vkAcquireNextImageKHR when timeout is not UINT32_MAX (otherwise that is not Valid Usage).

This is a recommendation of the specification:

If the number of currently acquired images is greater than this, vkAcquireNextImageKHR should not be called;

@mark-lunarg
Copy link
Contributor

Anybody think that statement is strong enough to warrant an error?

@krOoze
Copy link
Contributor Author

krOoze commented Nov 20, 2019

Well, "should not" is well defined in the specification. The user can do it, if he really really wants for some reason. It is well behaved; the user will either get the extra image, or VK_TIMEOUT or VK_NOT_READY (on a conformant driver that is).

BTW it was an error in layers before PR #1373

@mark-lunarg
Copy link
Contributor

Ah, there it is, then -- thanks for the definitive answer.

@mark-lunarg
Copy link
Contributor

Added to the BP tracking issue!

@shannon-lunarg shannon-lunarg added this to the sdk-1.1.130.0 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants