-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add layer configuration documentation #85
Conversation
6859005
to
befe1be
Compare
What about these issues in VVL? Will they be moved here? |
befe1be
to
5c1d846
Compare
This is still work in progress |
5c1d846
to
db394b4
Compare
db394b4
to
b02ea17
Compare
235c6ad
to
31a0d5f
Compare
* The library path has been updated using an operating system-specific mechanism such as: | ||
* Linux: adding the path to the layer's library .so with `LD_LIBRARY_PATH` | ||
* MacOS: adding the path to the layer's library .dylib with `DYLD_LIBRARY_PATH` | ||
3. The layer's library file is compiled for the same target and bitdepth (32 vs 64) as the application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bitdepth -> bitness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? This is from the original file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure. bitness is more common for arch and bitdepth is for color, but since it was used in original documentation I guess that’s correct too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some editorial suggestions. Learnt few things from this document.
a2b9546
to
bae8efc
Compare
bae8efc
to
207e4d1
Compare
207e4d1
to
dd5d337
Compare
This PR is moving some documentation from the validation layer to this repository, refactoring it and adding complementary information.