android: Update vulkan_wrapper, add source script #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cnorthrop
commented
May 16, 2018
cnorthrop
commented
- Finally check in the script that generates the wrapper
- Update the script to handle split vulkan files
- Update the checked in vulkan_wrapper.*
- Add a README descrbing how to use the script
cnorthrop
force-pushed
the
vulkan_wrapper_update
branch
from
2ec448e to
c68e9e6
Compare
* Finally check in the script that generates the wrapper * Update the script to handle split vulkan files * Update the checked in vulkan_wrapper.* * Add a README descrbing how to use the script
cnorthrop
force-pushed
the
vulkan_wrapper_update
branch
from
c68e9e6 to
a403891
Compare
arunsivaramanneo
referenced
this pull request
Jan 23, 2019
We didn't quite get the check on whether a format can be legally queried on a particular GPU quite right. We were checking against the instance version only. We need to check agains the driver's supported API version as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.