Avoid having to specify GLSLANG_REPO_ROOT when running CMAKE #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-lunarg
requested review from
TonyBarbour,
karl-lunarg,
jeremyk-lunarg and
jzulauf-lunarg
|
|
Obviates the need to set GLSLANG_REPO_ROOT or to have glslang otherwise installed for building this repo.
mark-lunarg
force-pushed
the
mark-master-glslang-pkg
branch
from
1407b7f to
561912b
Compare
|
Pushed to Master. |
arunsivaramanneo
referenced
this pull request
Jan 23, 2019
We didn't quite get the check on whether a format can be legally queried on a particular GPU quite right. We were checking against the instance version only. We need to check agains the driver's supported API version as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will download the glslangValidator binary automatically, avoiding external dependencies upon a separate glslang repo. Build.md doc updated with these instructions, along with how to set a location manually if a different glslangValidator version is wanted (for some crazy reason).
Note: The only glslang component currently used in this repo is glslangValidator, used to compile the two dinky shaders in cube and cubepp.