Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vkcube & vkcubepp: Select physical device before create surface if platform is WSI Display #1060

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

vkcube & vkcubepp: Select physical device before create surface if platform is WSI Display #1060

wants to merge 3 commits into from

Conversation

water-chika
Copy link
Contributor

If platform is WSI Display, vkcube will use physical device when creating surface.

@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@water-chika
Copy link
Contributor Author

This PR fix #1056.

@water-chika water-chika mentioned this pull request Dec 16, 2024
Open
charles-lunarg
charles-lunarg requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks decent, other than small grammar fixes in the comments.

cube/cube.cpp Outdated Show resolved Hide resolved
cube/cube.c Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 325307.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1589 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1589 passed.

@water-chika @charles-lunarg
Update cube/cube.c
3eaf8c4 
Co-authored-by: Charles Giessen <[email protected]>
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@water-chika @charles-lunarg
Update cube/cube.cpp
ee26615 
Co-authored-by: Charles Giessen <[email protected]>
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@water-chika
Copy link
Contributor Author

Thanks, I have commited the your fixes and I will squash the commits to 1 commit.

charles-lunarg
charles-lunarg approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.
And squashing would be very much appreciated :)

@water-chika
Copy link
Contributor Author

It seems that I could not merge PR. It shows only those with write access to this repository can merge pull requests.
@charles-lunarg, could you please help to squash commits and merge it?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@water-chika @ci-tester-lunarg @charles-lunarg