This repository has been archived by the owner on Jul 19, 2018. It is now read-only.
Tobin gh1259 aliasing #1264
Merged
Tobin gh1259 aliasing #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Buffer-Image Granularity section of the spec details what must be done to avoid having a linear buffer alias with a tiled image, but it does not state that such aliasing is a definite error. Demoting this check to a warning.
aliase->aliased
Zero-init the map_range variable before checking for aliasing of a mapped memory region.
tobine
requested review from
chrisforbes,
cdwfs,
mark-lunarg,
lentinem and
karl-lunarg
chrisforbes
approved these changes
Dec 13, 2016
mark-lunarg
approved these changes
Dec 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1259
This is a couple of simple updates to improves handling of aliasing in the validation layers.
Change an error to a warning and initialize a variable.