Fix non-sorted surface indexing #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 6981. |
|
CI Vulkan-Loader build # 1234 running. |
|
CI Vulkan-Loader build # 1234 passed. |
charles-lunarg
requested changes
Mar 24, 2022
|
CI Vulkan-Loader build queued with queue ID 7004. |
|
CI Vulkan-Loader build # 1235 running. |
|
CI Vulkan-Loader build # 1235 failed. |
1 similar comment
|
CI Vulkan-Loader build # 1235 failed. |
charles-lunarg
approved these changes
Mar 24, 2022
The physical device terminator was missing the ICD index in the non-sorted path. This caused crashes in Angle before it was realized that the sorting code was unintentionally disabled in that build path. Also, add tests to catch this case in the future in the WSI code, but this required converting all the TEST_F tests to TEST since Gtest didn't like mixing the 2 on my system. Finally, fix a few WSI error messages in the loader which were missing spaces. Fixes #863 for non-sorting paths
|
CI Vulkan-Loader build queued with queue ID 7013. |
|
CI Vulkan-Loader build # 1236 running. |
|
CI Vulkan-Loader build # 1236 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The physical device terminator was missing the ICD index in the
non-sorted path. This caused crashes in Angle before it was realized
that the sorting code was unintentionally disabled in that build
path.
Also, add tests to catch this case in the future.
Fixes #863 for non-sorting paths