Changes to enable high integrity testing #856
Conversation
|
CI Vulkan-Loader build queued with queue ID 14991. |
MarkY-LunarG
changed the title
|
CI Vulkan-Loader build # 1138 running. |
|
CI Vulkan-Loader build # 1138 passed. |
|
CI Vulkan-Loader build queued with queue ID 15001. |
|
CI Vulkan-Loader build # 1139 running. |
|
CI Vulkan-Loader build # 1139 passed. |
|
CI Vulkan-Loader build queued with queue ID 15042. |
MarkY-LunarG
changed the title
|
CI Vulkan-Loader build # 1140 running. |
Enable testing to check if the loader is running with elevated privileges. This is to make sure we're ignoring the appropriate environment variables in those scenarios to potentially avoid escalation exploits.
|
Going to update once more. Noticed I missed copyrights in the shim files. |
|
CI Vulkan-Loader build # 1140 passed. |
|
CI Vulkan-Loader build queued with queue ID 15078. |
|
CI Vulkan-Loader build # 1141 running. |
|
CI Vulkan-Loader build # 1141 passed. |
|
Hey Mark Your CL as expected broke ANGLE's integration with the loader on most platforms we test on. Can you confirm if this was intentional, and if so, how we can escalate to ask for some kind of bypass or solution? |
|
We don't intent to break ANGLE unless it was relying on potentially unsecured behavior. I can re-review the changes here and try to figure out which may be causing the issue. |
|
To be clear, we almost certainly rely on what you refer to as potentially unsecured behaviour. Because we don't ship as a platform loader this is not a security risk for our use case. If you could re-review the changes and quickly help us come up with a solution for us that would be most welcome. For more information see the conversation here: #281 I was being as direct as I could that these changes are expected to break ANGLE's integration. |
|
Ah, then its my bad for not picking up on what was being said. There is the USE_UNSAFE_FILE_SEARCH build option, which should disable the secure checking/admin mode disabling env-vars. I am not sure that helps here since it only applies to env-var logic, not to calls to This PR only adds a |
|
Charles, maybe what we need to do is add the ability for ANGLE to override this unsafe build option in our GN integration. The additional call to |
No description provided.