Consistent loader device ordering #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 10473. |
|
CI Vulkan-Loader build # 932 running. |
|
CI Vulkan-Loader build # 932 passed. |
|
CI Vulkan-Loader build queued with queue ID 10485. |
|
CI Vulkan-Loader build # 933 running. |
|
CI Vulkan-Loader build # 933 passed. |
|
CI Vulkan-Loader build queued with queue ID 11329. |
|
CI Vulkan-Loader build # 936 running. |
|
CI Vulkan-Loader build # 936 passed. |
|
CI Vulkan-Loader build queued with queue ID 12266. |
|
CI Vulkan-Loader build # 942 running. |
|
CI Vulkan-Loader build # 942 passed. |
The loader ICD ordering could be random on Linux based on using readdir to find ICD manifest files. This can result in random behaviors as applications that select only the first device can switch which device is used. To resolve this, we now sort based on device type and then internally to the types based on PCI bus information. This also introduces a VK_LOADER_DEFAULT_DEVICE environment variable that can be used to force a specific PCI device. This environment variable is actually a duplicate of the MESA_VK_DEVICE_SELECT variable, which is also looked for if the loader environment variable is not found. Note, that at least one ICD must support it for the extension to be used at all. So we only do the sorting if one ICD supports it. Fixes part of #657
|
CI Vulkan-Loader build queued with queue ID 15510. |
|
CI Vulkan-Loader build # 952 running. |
|
CI Vulkan-Loader build # 952 passed. |
charles-lunarg
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loader ICD ordering could be random on Linux based on using readdir
to find ICD manifest files. This can result in random behaviors as
applications that select only the first device can switch which device is
used. To resolve this, we now sort based on device type and then
internally to the types based on PCI bus information.
This also introduces a VK_LOADER_DEFAULT_DEVICE environment variable
that can be used to force a specific PCI device. This environment variable
is actually a duplicate of the MESA_VK_DEVICE_SELECT variable, which is
also looked for if the loader environment variable is not found.
Note, that at least one ICD must support it for the extension to be used at all.
So we only do the sorting if one ICD supports it.
Fixes part of #657