Debug utils terms #318
Merged
Debug utils terms #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9e08b59669bd301e3c5361ae4ea16102461fb34b
Change-Id: Ia59f3c34addca92cfa22f4396ea30deb445a1ffc
lenny-lunarg
force-pushed
the
debug_utils_terms
branch
from
515d907 to
167bb29
Compare
pdaniell-nv
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #116.
This PR addresses the bug where the loader returns an invalid function pointers when an application calls
vkGetInstanceProcAddron the methods from theVK_EXT_debug_utilsextension. Previously, the function pointers would run fine, but they would never call into the driver. This makes them call into the driver.I'd be lying if I said I was 100% happy with this change. I wound up adding terminators for each function in this extension because doing so allowed me to use the existing instance functionality for choosing which driver to call into. But I do think this should do the job. This is a very special case because debug utils is an instance extension that contains device level functions.