Check JSON API version in create instance #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some old drivers crash when calling vkGetInstanceProcAddr to get the vkEnumerateInstanceVersion entry point. This checks that the JSON API version is 1.1 before doing that to avoid the crash Change-Id: I85eac4e1ee38222c936c63484fb9f4353ba55ab0
lenny-lunarg
added
the
system integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old drivers crash when calling vkGetInstanceProcAddr to get the vkEnumerateInstanceVersion entry point. This checks that the JSON API version is 1.1 before doing that to avoid the crash
See #182 for the background on this PR.