Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when Filter Env-Vars act when settings file is active #1609

Conversation

charles-lunarg
Copy link
Collaborator

The logging to indicate that VK_LOADER_LAYERS_ENABLE and VK_LOADER_LAYERS_DISABLE turned on/off layers was not occuring when the settings file was active. This is due to layer enablement being done in enable_correct_layers_from_settings(), a newer function. which lacked the log functions.
This commit rectifies the lack of logging in the new function.

The logging to indicate that VK_LOADER_LAYERS_ENABLE and VK_LOADER_LAYERS_DISABLE
turned on/off layers was not occuring when the settings file was active. This
is due to layer enablement being done in `enable_correct_layers_from_settings()`,
a newer function. which lacked the log functions.
This commit rectifies the lack of logging in the new function.
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 306947.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2798 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2798 passed.

@charles-lunarg charles-lunarg merged commit 63dcb0a into KhronosGroup:main Nov 21, 2024
44 checks passed
@charles-lunarg charles-lunarg deleted the fix_env_vars_not_loggin_when_settings_layer_is_active branch November 21, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants