Fix how rowExtent and sliceExtent are calculated for copy operations #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erations `bufferRowLength` and `bufferImageHeight` are specified in texels, not bytes, therefore it is necessary to multiply then by the block size to get the correct row extent and slice extent in bytes.
|
|
pdaniell-nv
approved these changes
Apr 3, 2024
|
Intersects with internal MR: https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6588 |
|
Cool, we can close this, looks like Tobias' PR covers this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufferRowLengthandbufferImageHeightare specified in texels, not bytes, therefore it is necessary to multiply them by the block size to get the correct row extent and slice extent in bytes.