Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move description of "half" to the right table #83

Merged

Conversation

keryell
Copy link
Member

@keryell keryell commented Mar 24, 2020

half is not a C++ native type but an additional SYCL scalar data type.

This should close #40

Also remove std::size_t from the table about fundamental types.

half is not a C++ native type but an additional SYCL scalar data type.

This should close KhronosGroup#40
@keryell keryell added the bug Something isn't working label Mar 24, 2020
@keryell keryell requested a review from bader March 24, 2020 19:04
@bader bader requested review from AerialMantis and mkinsner March 25, 2020 10:15
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@mkinsner mkinsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe that size_t has the same problem and should be moved as well. It's not a fundamental type in C++.

@keryell keryell force-pushed the ronan/SYCL-1.2.1/pub-issue-40 branch from 6406e43 to 92121bb Compare March 26, 2020 01:19
@keryell
Copy link
Member Author

keryell commented Mar 26, 2020

LGTM. I believe that size_t has the same problem and should be moved as well. It's not a fundamental type in C++.

Good point.

Since I was working on it I also removed std::size_t from the table about fundamental types.

Since it does exist in C++ already it does not to be declared under cl::sycl::.

@keryell keryell merged commit 6673a38 into KhronosGroup:SYCL-1.2.1/master Apr 6, 2020
bader added a commit to bader/llvm that referenced this pull request Nov 13, 2020
`cl::sycl::half` has been added to the specification by
KhronosGroup/SYCL-Docs#83.
bader added a commit to intel/llvm that referenced this pull request Nov 14, 2020
`cl::sycl::half` has been added to the specification by
KhronosGroup/SYCL-Docs#83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace for half data type: cl::sycl or no namespace?
4 participants