Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test plan for sycl_khr_free_function_commands #1021

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a test plan for sycl_khr_free_function_commands #1021

wants to merge 2 commits into from

Conversation

KornevNikita
Copy link
Contributor

Spec: KhronosGroup/SYCL-Docs#644
In general this is a copy-paste of test_plans/oneapi/enqueue_functions.asciidoc

@KornevNikita
Add a test plan for sycl_khr_free_function_commands
f14df0c 
Spec: KhronosGroup/SYCL-Docs#644
In general this is a copy-paste of test_plans/oneapi/enqueue_functions.asciidoc
@KornevNikita KornevNikita requested review from gmlueck and a team as code owners January 20, 2025 12:02
@KornevNikita KornevNikita marked this pull request as draft January 22, 2025 17:10
keryell
keryell approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.

@TApplencourt TApplencourt self-assigned this Jan 23, 2025
KornevNikita added a commit to KornevNikita/SYCL-CTS that referenced this pull request Jan 27, 2025
@KornevNikita
Add tests for sycl_khr_free_function_commands
275b296 
Spec: KhronosGroup/SYCL-Docs#644
Test plan: KhronosGroup#1021
KornevNikita added a commit to KornevNikita/SYCL-CTS that referenced this pull request Jan 27, 2025
@KornevNikita
Add tests for sycl_khr_free_function_commands
2a82250 
Spec: KhronosGroup/SYCL-Docs#644
Test plan: KhronosGroup#1021
@KornevNikita KornevNikita mentioned this pull request Jan 27, 2025
Open
@gmlueck gmlueck requested a review from Pennycook January 29, 2025 20:44
@gmlueck
Copy link
Contributor

gmlueck commented Jan 29, 2025

Adding @Pennycook as reviewer instead of me. I think you are a better reviewer for this. Note that #1027 has already implemented this test plan.

Pennycook
Pennycook requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good. I just spotted two minor things.

test_plans/khr/free_function_commands.asciidoc Outdated Show resolved Hide resolved
test_plans/khr/free_function_commands.asciidoc Outdated Show resolved Hide resolved
@KornevNikita KornevNikita marked this pull request as ready for review February 3, 2025 16:21
Pennycook
Pennycook approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if my approval will count or if @gmlueck also needs to approve, so pinging him just in case...

@gmlueck
Copy link
Contributor

gmlueck commented Feb 3, 2025

I'm not sure if my approval will count or if @gmlueck also needs to approve, so pinging him just in case...

I think @Pennycook 's approval counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

@Pennycook Pennycook Pennycook approved these changes

@gmlueck gmlueck Awaiting requested review from gmlueck gmlueck is a code owner

Assignees

@TApplencourt TApplencourt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KornevNikita @gmlueck @Pennycook @keryell @TApplencourt