Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: add StorageImageWriteWithoutFormat to trimm pass #5860

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Oct 22, 2024

This will be required to fix microsoft/DirectXShaderCompiler#6981

@Keenuts Keenuts enabled auto-merge (squash) October 24, 2024 09:36
@Keenuts
Copy link
Contributor Author

Keenuts commented Oct 24, 2024

pushing an empy commit to unblock CI-check-format

@Keenuts Keenuts merged commit 298055b into KhronosGroup:main Oct 24, 2024
22 of 23 checks passed
@Keenuts Keenuts deleted the add-write-without-format branch October 24, 2024 11:09
akaday added a commit to akaday/SPIRV-Tools that referenced this pull request Oct 25, 2024
…Group#5859

Add validation for SPV_NV_tensor_addressing and SPV_NV_cooperative_matrix2, and update the CHANGES file.

* Add validation for SPV_NV_tensor_addressing and SPV_NV_cooperative_matrix2 in `source/val/validate.cpp`.
* Add StorageImageWriteWithoutFormat to trimm pass in `source/opt/loop_unroller.cpp`.
* Add KHR_fragment_shading_rate to allowlist in `source/opt/loop_fusion.cpp`.
* Update the CHANGES file to mention the changes from pull requests KhronosGroup#5865, KhronosGroup#5860, and KhronosGroup#5859.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/EpicGames/SPIRV-Tools?shareId=XXXX-XXXX-XXXX-XXXX).
mmoult pushed a commit to mmoult/SPIRV-Tools that referenced this pull request Nov 16, 2024
)

* opt: add StorageImageWriteWithoutFormat to trimm pass

---------

Signed-off-by: Nathan Gauër <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIR-V] Unable to set 'unknown' format when using image_format attribute
2 participants