-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPV_EXT_mesh_shader related tools changes #4915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
pmistryNV
force-pushed
the
GL_EXT_mesh_shader
branch
2 times, most recently
from
September 1, 2022 17:45
2c78e5f
to
2687d70
Compare
pmistryNV
force-pushed
the
GL_EXT_mesh_shader
branch
from
September 1, 2022 19:14
2687d70
to
c3c4344
Compare
alan-baker
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow up on the spec bug separately, but I'd like to address the version requirement before merging this PR.
- Added validation rule to support EXT_mesh_shader from SPIRV 1.4 onwards
pmistryNV
force-pushed
the
GL_EXT_mesh_shader
branch
from
September 1, 2022 21:12
c3c4344
to
2c89eda
Compare
alan-baker
approved these changes
Sep 1, 2022
Finished? |
jeremyg-lunarg
added a commit
to jeremyg-lunarg/Vulkan-ValidationLayers
that referenced
this pull request
Sep 6, 2022
KhronosGroup/SPIRV-Headers#288 KhronosGroup/SPIRV-Tools#4915 Reenable spv::CapabilityMeshShadingEXT in spirv_validation_generator.py Fixes KhronosGroup#4515
jeremyg-lunarg
added a commit
to KhronosGroup/Vulkan-ValidationLayers
that referenced
this pull request
Sep 6, 2022
KhronosGroup/SPIRV-Headers#288 KhronosGroup/SPIRV-Tools#4915 Reenable spv::CapabilityMeshShadingEXT in spirv_validation_generator.py Fixes #4515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.