Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update googletest to a newer commit #5039

Closed
dneto0 opened this issue Dec 21, 2022 · 2 comments · Fixed by #5045
Closed

deps: update googletest to a newer commit #5039

dneto0 opened this issue Dec 21, 2022 · 2 comments · Fixed by #5045

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Dec 21, 2022

The DEPS file pins googletest to an old specific commit.
I recall doing that because of unwanted build breakages.

Other contraints:

  • We also wanted to make sure that developers would only need a compiler that could compile C++11. That means no later than googletest v1.12.1
    • However, the supported / tested compilers can all do much better than just C++11. We can allow requiring later versions of C++11. I think the major constraint here is needing to work with VS 2017.
  • We prefer to avoid requiring extra dependencies like abseil. We don't need very fancy features of googletest. Just very old things.
@dneto0
Copy link
Collaborator Author

dneto0 commented Dec 21, 2022

When I update to top-of-tree googletest, the bazel build fails.
Because the googletest BUILD.bazel file doesn't specify -std=c++14 when needed. google/googletest#4098
I have a fix in flight: google/googletest#4100

@dneto0
Copy link
Collaborator Author

dneto0 commented Dec 22, 2022

Heh. Googletest depends on abseil now, and Abseil's rules for API stability but no ABI stability mean you're not supposed to set C++ standard inside the Bazel file. Instead do it on the command line.

See https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/abseil-cpp/FAQ.md#how-to-i-set-the-c_dialect-used-to-build-abseil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant