Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validation rule in NonSemantic.Shader.DebugInfo.100 DebugLine #302

Closed
alan-baker opened this issue Dec 12, 2024 · 0 comments · Fixed by #303
Closed

Incorrect validation rule in NonSemantic.Shader.DebugInfo.100 DebugLine #302

alan-baker opened this issue Dec 12, 2024 · 0 comments · Fixed by #303

Comments

@alan-baker
Copy link
Contributor

See DebugLine.

Line Start is the of a 32-bit integer OpConstant denoting the source line number where the location begins.

Line End is the of a 32-bit integer OpConstant denoting the source line number where the location ends. This may be the same as Line Start if the location doesn’t cover multiple lines.

Column Start is the of a 32-bit integer OpConstant denoting the source column number where the location begins.

Column End is the of a 32-bit integer OpConstant denoting the source column number where the location ends. This must be greater than or equal to Column Start.

The validation for Column End should only apply if Line Start equals Line End. KhronosGroup/SPIRV-Tools#5846 implemented the rule as is, but that causes some multi-line uses to be considered invalid.

alan-baker added a commit to alan-baker/SPIRV-Registry that referenced this issue Dec 16, 2024
Fixes KhronosGroup#302

* Column End >= Column Start only if Line End == Line Start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant