Add baseline Spec Constant API support #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoticbob
approved these changes
Jan 10, 2024
spencer-lunarg
force-pushed
the
spencer-spec-constant2
branch
from
26c9751 to
c07ff56
Compare
|
Hi @spencer-lunarg ! The way I set things up is that I use variable names in the frontend code, that later get resolved to specialization constant ids in the backend code. So it would help me a lot if I could also access the name of the constant in 'SpvReflectSpecializationConstant'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal is not to dismiss #197 or #154 but instead create a more gradual first step to at least get "something" as a baseline for support
With this there is a
spvReflectEnumerateSpecializationConstantswhich can be queried and returned aSpvReflectSpecializationConstantobject.For now
SpvReflectSpecializationConstantis the bare minimum until it is better examined (and tested) what should be added, but then it will be a more simple additive process to what is already exposed(cc @muraj @zbendefy it would be awesome to get feedback if this helps solve your problems or not)