Fix SPIRVCopyMemory::validate() #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769
svenvh
force-pushed
the
copymemory-asserts
branch
from
e965976 to
29501f1
Compare
vmaksimo
approved these changes
Oct 21, 2024
MrSidims
approved these changes
Oct 21, 2024
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 25, 2024
The asserts should be checking the `Target` member variable; `Id` is not used for this class. Only fix the wrong asserts for now; proper handling and testing of `OpCopyMemory` will be done in a followup commit. Contributes to KhronosGroup#2769 (cherry picked from commit 9d2926d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asserts should be checking the
Targetmember variable;Idis not used for this class.Only fix the wrong asserts for now; proper handling and testing of
OpCopyMemorywill be done in a followup commit.Contributes to #2769