Allow specialization constant length arrays #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
force-pushed
the
spec-const-len-arr
branch
from
71be466 to
afd3075
Compare
MrSidims
reviewed
Mar 4, 2024
|
@MrSidims any further comments on my findings? |
SPIR-V arrays can have their length specified via a specialization constant. In case an `alloca` instruction uses a specialization constant `s` as length, generate an array variable of length `s`. Signed-off-by: Victor Perez <[email protected]>
Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
spec-const-len-arr
branch
from
c5aff00 to
bcf1414
Compare
svenvh
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V arrays can have their length specified via a specialization constant. In case an
allocainstruction uses a specialization constantsas length, generate an array variable of lengths.