Fix cooperative matrix prefetch test (scope parameter) #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrSidims Can you please have a look |
MrSidims
approved these changes
Nov 27, 2023
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 13, 2024
…2234) - change Scope argument to one of two available options: ScopeWorkgroup/ScopeWorkgroup - fix arguments order in calls to OpCooperativeMatrixLoadKHR()
YuriPlyakhin
pushed a commit
to YuriPlyakhin/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 3, 2024
…2234) - change Scope argument to one of two available options: ScopeWorkgroup/ScopeWorkgroup - fix arguments order in calls to OpCooperativeMatrixLoadKHR()
MrSidims
pushed a commit
that referenced
this pull request
Jul 4, 2024
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator. * Fix cooperative matrix prefetch test (scope parameter) (#2234) - change Scope argument to one of two available options: ScopeWorkgroup/ScopeWorkgroup - fix arguments order in calls to OpCooperativeMatrixLoadKHR() * Remove CoordX and CoordY arguments of OpCooperativeMatrixPrefetchINTEL According to a new specification, CoordX and CoordY parameters are not needed for prefetch in CooperativeMatrixPrefetchINTEL(), only offset pointer is enough. This PR is to fix support for joint_matrix_prefetch in SPIRV according to the new specification. Co-authored-by: Vyacheslav Levytskyy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope argument to one of two available options: ScopeWorkgroup/ScopeWorkgroup.