Add out-of-bounds check #2380
Closed
Add out-of-bounds check #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tygyh
force-pushed
the
Prevent-buffer-overread
branch
from
45a490c to
32384a3
Compare
tygyh
force-pushed
the
Prevent-buffer-overread
branch
from
32384a3 to
9ab1b3c
Compare
|
When is this case ever hit? Does it fix a concrete bug? |
None which I know of. I tried to fix this since this project is a dependency for a project I'm working on and I wanted to fix it at the root. |
I'm not comfortable adding arbitrary code like this when it doesn't solve a concrete problem in SPIRV-Cross. An assert() for being in-range would be acceptable, but actual range-checking should be done on the outside. |
|
Closing as not being relevant for upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the buffer from size is used as an array index. This value could be one larger than the last possible index of the array, causing a buffer overread.