Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filesystem: Fix theoretical bug on Linux. #72

Merged
merged 2 commits into from
Jul 11, 2019
Merged

filesystem: Fix theoretical bug on Linux. #72

merged 2 commits into from
Jul 11, 2019

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Jun 26, 2019

We'd try to close even a null directory.

Found by clang-tidy.

perhaps @ChristophHaag and/or @Ralith could review?

@rpavlik
filesystem: Fix theoretical bug on Linux.
83a40db 
We'd try to close even a null directory.

Found by clang-tidy.
Ralith
Ralith approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though perhaps it should return false as the try/catch logic seems to indicate is expected for errors? Use seems to be to skip walking the vector if false is returned, which is reasonable in that case.

@rpavlik
Copy link
Contributor Author

rpavlik commented Jun 27, 2019

ok, that makes sense.

@rpavlik rpavlik merged commit 4bea7d7 into master Jul 11, 2019
@rpavlik rpavlik deleted the loader-closedir branch July 11, 2019 18:14
rpavlik added a commit that referenced this pull request Jan 28, 2021
@rpavlik
OpenXR SDK 1.0.14 (2021-01-27)
42b694c 
This release contains a collection of fixes and improvements, including
one new vendor extension. Notably, we have relicensed all files that
become part of the loader, so the loader may be “Apache-2.0 OR MIT” for
downstream license compatibility.

-   Registry
    -   Add new XR_FB_android_surface_swapchain_create vendor extension.
        (internal MR 1939, internal issue 1493, internal MR 1968)
    -   Add missing optional attributes to XR_KHR_vulkan_enable2
        structs. Fixes validation layer. (OpenXR-Docs/#72)
    -   Correction to locationFlags field in XrHandJointLocationEXT to
        be optional. (internal MR 1945)
    -   Reserve vendor extensions for Varjo. (internal MR 1935)
    -   Reserve vendor extensions for Magic Leap. (internal MR 1967,
        internal MR 1970)
    -   Reserve extension number 143 to 148 for MSFT extensions.
        (internal MR 1969)
    -   Update Magic Leap ID and contact information. (internal MR 1967)
-   SDK
    -   Add ./ to the start of the library name in API layer manifests
        on Windows, so they are treated as a relative path. (internal MR
        1975)
    -   Fix searching for prerequisites in generated CMake config files.
        (internal MR 1963)
    -   Start shipping the OpenXR API layers with the release artifacts.
        (internal MR 1975)
    -   cmake: Debug library uses d suffix on Windows. CMake
        OPENXR_DEBUG_POSTFIX variable can be set to something else to
        change it. (OpenXR-SDK-Source/#229)
    -   hello_xr: Remove redundant call to xrInitializeLoaderKHR.
        (internal MR 1933)
    -   hello_xr: Return supported sample count as 1 for GLES, GL and
        D3D11. (internal MR 1962)
    -   hello_xr: Use android.app.NativeActivity correctly in place of
        NativeActivity subclass. (internal MR 1976)
    -   hello_xr: On Vulkan, explicitly add surface extensions for
        mirror window. (OpenXR-SDK-Source/#230, internal MR 1934)
    -   loader: Relicense all files that become part of the loader, so
        the loader may be “Apache-2.0 OR MIT” for downstream license
        compatibility. (internal MR 1937, internal issue 1449,
        OpenXR-SDK-Source/#205)
    -   loader: Protect against the application overriding loader
        symbols. (internal MR 1961)
    -   loader: Handle JSON files in the search path that are not
        objects. (internal MR 1979)
rhabacker pushed a commit to rhabacker/OpenXR-SDK-Source that referenced this pull request Nov 16, 2022
@rpavlik
OpenXR SDK 1.0.14 (2021-01-27)
5900c51 
This release contains a collection of fixes and improvements, including
one new vendor extension. Notably, we have relicensed all files that
become part of the loader, so the loader may be “Apache-2.0 OR MIT” for
downstream license compatibility.

-   Registry
    -   Add new XR_FB_android_surface_swapchain_create vendor extension.
        (internal MR 1939, internal issue 1493, internal MR 1968)
    -   Add missing optional attributes to XR_KHR_vulkan_enable2
        structs. Fixes validation layer. (OpenXR-Docs/KhronosGroup#72)
    -   Correction to locationFlags field in XrHandJointLocationEXT to
        be optional. (internal MR 1945)
    -   Reserve vendor extensions for Varjo. (internal MR 1935)
    -   Reserve vendor extensions for Magic Leap. (internal MR 1967,
        internal MR 1970)
    -   Reserve extension number 143 to 148 for MSFT extensions.
        (internal MR 1969)
    -   Update Magic Leap ID and contact information. (internal MR 1967)
-   SDK
    -   Add ./ to the start of the library name in API layer manifests
        on Windows, so they are treated as a relative path. (internal MR
        1975)
    -   Fix searching for prerequisites in generated CMake config files.
        (internal MR 1963)
    -   Start shipping the OpenXR API layers with the release artifacts.
        (internal MR 1975)
    -   cmake: Debug library uses d suffix on Windows. CMake
        OPENXR_DEBUG_POSTFIX variable can be set to something else to
        change it. (OpenXR-SDK-Source/KhronosGroup#229)
    -   hello_xr: Remove redundant call to xrInitializeLoaderKHR.
        (internal MR 1933)
    -   hello_xr: Return supported sample count as 1 for GLES, GL and
        D3D11. (internal MR 1962)
    -   hello_xr: Use android.app.NativeActivity correctly in place of
        NativeActivity subclass. (internal MR 1976)
    -   hello_xr: On Vulkan, explicitly add surface extensions for
        mirror window. (OpenXR-SDK-Source/KhronosGroup#230, internal MR 1934)
    -   loader: Relicense all files that become part of the loader, so
        the loader may be “Apache-2.0 OR MIT” for downstream license
        compatibility. (internal MR 1937, internal issue 1449,
        OpenXR-SDK-Source/KhronosGroup#205)
    -   loader: Protect against the application overriding loader
        symbols. (internal MR 1961)
    -   loader: Handle JSON files in the search path that are not
        objects. (internal MR 1979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpavlik @Ralith