-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Fix typo in declspec keyword #302
Conversation
I am not sure what I should do with the CLA check. I have signed CLA in other vulkan repositories without any issue. |
An issue (number 1691) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1691 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
There are two CLAs depending on whether the repo is mostly spec text, or mixed spec and code. (or it might be per repo? I don't remember) @KhronosWebservices ? Good catch, sorry I didn't notice it until now. You should be able to rebase on main and the CI will work again. Can you add a changelog fragment called |
OK that status literally updated while I was editing my comment, looks like your CLA is good to go now. |
This fixes the following errors with mingw toolchain. OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:17:10: error: expected constructor, destructor, or type conversion before '(' token 17 | _declspec(dllexport) DWORD NvOptimusEnablement = 0x00000001; | ^ OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:19:10: error: expected constructor, destructor, or type conversion before '(' token 19 | _declspec(dllexport) DWORD AmdPowerXpressRequestHighPerformance = 0x00000001; | ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this!
cla-assistant can be slow if experiencing a heavy load. This repository is using the Apache 2.0 CLA. |
This fixes the following errors with mingw toolchain.