Add file formatting checks to CI #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlik
requested changes
Nov 24, 2020
aaronfranke
force-pushed
the
format-ci
branch
from
8b4aec6 to
cbb0907
Compare
aaronfranke
force-pushed
the
format-ci
branch
from
cbb0907 to
ff82d6f
Compare
|
@rpavlik Requesting review and merge. I'm not sure what else I can do with this PR, I've responded to your feedback as well as I can. I think the best course of action is to merge it, and then you can make any further changes as needed. |
|
sorry for not merging this sooner - it looks good, I was just having some trouble getting it to run on our CI. I did run it before the last release, I think, despite not being able to merge. This one is on me now. |
rpavlik
approved these changes
Dec 17, 2020
rpavlik
approved these changes
Apr 2, 2021
|
Thanks - figured out my wsl problem and got it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #208. The formatting script runs on every text file except for those in
external/andsrc/external/.Fingers crossed that the CI checks will work, in previous implementations I had this script set up through GitHub Actions, but since this repo uses Azure Pipelines I wrote a config for that by copying the clang-format one. It doesn't seem that the new checks are running with this PR, that might change if it's merged but I'm not sure, I'm not familiar with Azure Pipelines.