Fix cmake target export when installing both Release and Debug config on Windows #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g config on Windows
rpavlik
approved these changes
Sep 18, 2020
rpavlik
added a commit
that referenced
this pull request
Sep 26, 2020
This release features a number of new ratified KHR extensions, as well
as a new vendor extension.
- Registry
- Add ratified XR_KHR_vulkan_enable2 Khronos extension. (internal
MR 1627, internal issue 1249, internal issue 1283, internal MR
1863)
- Add ratified XR_KHR_loader_init Khronos extension. (internal MR
1744)
- Add ratified XR_KHR_loader_init_android Khronos extension.
(internal MR 1744)
- Add ratified XR_KHR_composition_layer_equirect2 Khronos
extension. (internal MR 1746)
- Add ratified XR_KHR_composition_layer_color_scale_bias Khronos
extension. (internal MR 1762)
- Add XR_MSFT_controller_model extension. (internal MR 1832)
- Add vendor tag LIV for LIV Inc. (internal MR 1896)
- Fix structextends attribute of XrHandPoseTypeInfoMSFT.
(OpenXR-SDK-Source/#207)
- schema: Update to permit aliases for commands and struct types.
(Already supported by tooling.) (internal MR 1627)
- SDK
- cmake: fix openxr_loader target export when installing both
Release and Debug config on Windows. (OpenXR-SDK-Source/#206)
- hello_xr: Support the new XR_KHR_vulkan_enable2 extension.
(internal MR 1627)
- hello_xr: Use the XR_KHR_loader_init_android extension on
Android. (internal MR 1903)
- layers: Fix ARM builds by re-adding function attributes.
(OpenXR-SDK-Source/#193)
- Misc
- Clean up trailing whitespace, byte-order marks, anda ensure
trailing newlines. (OpenXR-SDK-Source/#208)
rhabacker
pushed a commit
to rhabacker/OpenXR-SDK-Source
that referenced
this pull request
Nov 16, 2022
This release features a number of new ratified KHR extensions, as well
as a new vendor extension.
- Registry
- Add ratified XR_KHR_vulkan_enable2 Khronos extension. (internal
MR 1627, internal issue 1249, internal issue 1283, internal MR
1863)
- Add ratified XR_KHR_loader_init Khronos extension. (internal MR
1744)
- Add ratified XR_KHR_loader_init_android Khronos extension.
(internal MR 1744)
- Add ratified XR_KHR_composition_layer_equirect2 Khronos
extension. (internal MR 1746)
- Add ratified XR_KHR_composition_layer_color_scale_bias Khronos
extension. (internal MR 1762)
- Add XR_MSFT_controller_model extension. (internal MR 1832)
- Add vendor tag LIV for LIV Inc. (internal MR 1896)
- Fix structextends attribute of XrHandPoseTypeInfoMSFT.
(OpenXR-SDK-Source/KhronosGroup#207)
- schema: Update to permit aliases for commands and struct types.
(Already supported by tooling.) (internal MR 1627)
- SDK
- cmake: fix openxr_loader target export when installing both
Release and Debug config on Windows. (OpenXR-SDK-Source/KhronosGroup#206)
- hello_xr: Support the new XR_KHR_vulkan_enable2 extension.
(internal MR 1627)
- hello_xr: Use the XR_KHR_loader_init_android extension on
Android. (internal MR 1903)
- layers: Fix ARM builds by re-adding function attributes.
(OpenXR-SDK-Source/KhronosGroup#193)
- Misc
- Clean up trailing whitespace, byte-order marks, anda ensure
trailing newlines. (OpenXR-SDK-Source/KhronosGroup#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the library was always installed in
lib/openxr_loader.lib. If we tried to installed both Release and Debug, one will overwrite the other, resulting in linking error during application compilation.The fix is to install the debug lib to another file. With this fix, the debug static lib will be at
lib/Debug/openxr_loader.lib. For dll, it will be installed inbin/Debug/openxr_loader.dll.I tested for both static and dynamic libraries.