Fix Visual Studio 19 16.6 build #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good to me! Would you be willing to add a "changelog fragment" in here https://github.com/KhronosGroup/OpenXR-SDK-Source/tree/master/changes/sdk ? There are readme files there and the parent directory. You'd call it ---
- issue.184.gh.OpenXR-SDK-Source
---
Changelog fragment goes here. |
rpavlik
added
in hello_xr
waiting for reporter
needs changelog fragment
rpavlik
approved these changes
May 5, 2020
rpavlik
approved these changes
May 6, 2020
|
Looks great, thanks for your contribution! |
rpavlik
added a commit
that referenced
this pull request
May 29, 2020
- Registry
- Add an author ID, and reserve a vendor extension for Huawei.
(OpenXR-Docs/#46)
- Reserve vendor extensions for future LunarG overlay and input
focus functionality. (internal MR 1720)
- Reserve vendor extensions for Microsoft. (internal MR 1723)
- Add XR_EXT_hand_tracking multi-vendor extension. (internal MR
1554, internal issue 1266, internal issue 1267, internal issue
1268, internal issue 1269)
- Add XR_HUAWEI_controller_interaction vendor extension.
(OpenXR-Docs/#47)
- Add XR_MNDX_egl_enable provisional vendor extension.
(OpenXR-Docs/#48)
- Add XR_MSFT_spatial_graph_bridge vendor extension. (internal MR
1730)
- Add XR_MSFT_secondary_view_configuration and
XR_MSFT_first_person_observer vendor extensions. (internal MR
1731)
- Add XR_MSFT_hand_mesh_tracking vendor extension. (internal MR
1736)
- Fix missing space in XML definition of
XrSpatialAnchorCreateInfoMSFT. (internal MR 1742, internal issue
1351, OpenXR-SDK-Source/#187)
- Update a number of contacts for author/vendor tags. (internal MR
1788, internal issue 1326)
- SDK
- Replaced usage of the _DEBUG macro with NDEBUG. (internal MR
1756)
- Allow disabling of std::filesystem usage via CMake, and detect
if it’s available and what its requirements are.
(OpenXR-SDK-Source/#192, OpenXR-SDK-Source/#188)
- CI: Modifications to Azure DevOps build pipeline. Now builds UWP
loader DLLs in addition to Win32 loader DLLs. No longer builds
static loader libraries due to linkability concerns. Re-arranged
release artifact zip to distinguish architecture from 32-bit or
64-bit.
- Loader: Replace global static initializers with functions that
return static locals. With this change, code that includes
OpenXR doesn’t have to page in this code and initialize these
during startup. (OpenXR-SDK-Source/#173)
- Loader: Unload runtime when xrCreateInstance fails. (internal MR
1778)
- Loader: Add “info”-level debug messages listing all the places
that we look for the OpenXR active runtime manifest.
(OpenXR-SDK-Source/#190)
- Validation Layer: Fix crash in dereferencing a nullptr optional
array handle when the count > 0. (internal MR 1709,
OpenXR-SDK-Source/#161, internal issue 1322)
- Validation Layer: Fix static analysis error and possible loss of
validation error. (internal MR 1715, OpenXR-SDK-Source/#160,
internal issue 1321)
- Validation Layer: Simplify some generated code, and minor
performance improvements. (OpenXR-SDK-Source/#176)
- API Dump Layer: Fix crash in dereferencing a nullptr while
constructing a std::string. (internal MR 1712,
OpenXR-SDK-Source/#162, internal issue 1323)
- hello_xr: Fix releasing a swapchain image with the incorrect
image layout. (internal MR 1755)
- hello_xr: Prefer VK_LAYER_KHRONOS_validation over
VK_LAYER_LUNARG_standard_validation when available. (internal MR
1755)
- hello_xr: Optimizations to D3D12 plugin to avoid GPU pipeline
stall. (internal MR 1770) (OpenXR-SDK-Source/#175)
- hello_xr: Fix build with Vulkan headers 1.2.136.
(OpenXR-SDK-Source/#181, OpenXR-SDK-Source/#180, internal issue
1347)
- hello_xr: Fix build with Visual Studio 16.6.
(OpenXR-SDK-Source/#186, OpenXR-SDK-Source/#184)
rhabacker
pushed a commit
to rhabacker/OpenXR-SDK-Source
that referenced
this pull request
Nov 16, 2022
- Registry
- Add an author ID, and reserve a vendor extension for Huawei.
(OpenXR-Docs/KhronosGroup#46)
- Reserve vendor extensions for future LunarG overlay and input
focus functionality. (internal MR 1720)
- Reserve vendor extensions for Microsoft. (internal MR 1723)
- Add XR_EXT_hand_tracking multi-vendor extension. (internal MR
1554, internal issue 1266, internal issue 1267, internal issue
1268, internal issue 1269)
- Add XR_HUAWEI_controller_interaction vendor extension.
(OpenXR-Docs/KhronosGroup#47)
- Add XR_MNDX_egl_enable provisional vendor extension.
(OpenXR-Docs/KhronosGroup#48)
- Add XR_MSFT_spatial_graph_bridge vendor extension. (internal MR
1730)
- Add XR_MSFT_secondary_view_configuration and
XR_MSFT_first_person_observer vendor extensions. (internal MR
1731)
- Add XR_MSFT_hand_mesh_tracking vendor extension. (internal MR
1736)
- Fix missing space in XML definition of
XrSpatialAnchorCreateInfoMSFT. (internal MR 1742, internal issue
1351, OpenXR-SDK-Source/KhronosGroup#187)
- Update a number of contacts for author/vendor tags. (internal MR
1788, internal issue 1326)
- SDK
- Replaced usage of the _DEBUG macro with NDEBUG. (internal MR
1756)
- Allow disabling of std::filesystem usage via CMake, and detect
if it’s available and what its requirements are.
(OpenXR-SDK-Source/KhronosGroup#192, OpenXR-SDK-Source/KhronosGroup#188)
- CI: Modifications to Azure DevOps build pipeline. Now builds UWP
loader DLLs in addition to Win32 loader DLLs. No longer builds
static loader libraries due to linkability concerns. Re-arranged
release artifact zip to distinguish architecture from 32-bit or
64-bit.
- Loader: Replace global static initializers with functions that
return static locals. With this change, code that includes
OpenXR doesn’t have to page in this code and initialize these
during startup. (OpenXR-SDK-Source/KhronosGroup#173)
- Loader: Unload runtime when xrCreateInstance fails. (internal MR
1778)
- Loader: Add “info”-level debug messages listing all the places
that we look for the OpenXR active runtime manifest.
(OpenXR-SDK-Source/KhronosGroup#190)
- Validation Layer: Fix crash in dereferencing a nullptr optional
array handle when the count > 0. (internal MR 1709,
OpenXR-SDK-Source/KhronosGroup#161, internal issue 1322)
- Validation Layer: Fix static analysis error and possible loss of
validation error. (internal MR 1715, OpenXR-SDK-Source/KhronosGroup#160,
internal issue 1321)
- Validation Layer: Simplify some generated code, and minor
performance improvements. (OpenXR-SDK-Source/KhronosGroup#176)
- API Dump Layer: Fix crash in dereferencing a nullptr while
constructing a std::string. (internal MR 1712,
OpenXR-SDK-Source/KhronosGroup#162, internal issue 1323)
- hello_xr: Fix releasing a swapchain image with the incorrect
image layout. (internal MR 1755)
- hello_xr: Prefer VK_LAYER_KHRONOS_validation over
VK_LAYER_LUNARG_standard_validation when available. (internal MR
1755)
- hello_xr: Optimizations to D3D12 plugin to avoid GPU pipeline
stall. (internal MR 1770) (OpenXR-SDK-Source/KhronosGroup#175)
- hello_xr: Fix build with Vulkan headers 1.2.136.
(OpenXR-SDK-Source/KhronosGroup#181, OpenXR-SDK-Source/KhronosGroup#180, internal issue
1347)
- hello_xr: Fix build with Visual Studio 16.6.
(OpenXR-SDK-Source/KhronosGroup#186, OpenXR-SDK-Source/KhronosGroup#184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix related to #184
Need to use Visual Studio Preview to reproduce.