Link patches #149
Merged
Link patches #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlik
force-pushed
the
link-patches
branch
2 times, most recently
from
f4a1c0b to
427747b
Compare
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
rpavlik
force-pushed
the
link-patches
branch
from
427747b to
f5f750e
Compare
|
For easier review, here's the diff without the (now) last 2 patches which are more formatting than actual change: https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/149/files/e32a4c2ae393720468465816ae20366088c65d35..8ada0f8d3200cab6433b8ad6626ddedc0b95c581 |
rpavlik
force-pushed
the
link-patches
branch
2 times, most recently
from
9d09fee to
d09ce9d
Compare
|
There, satisfied CI :) |
Open
|
@ChristophHaag can you sanity check this patch please? |
Helping to untangle the deps Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
Signed-off-by: Ryan Pavlik <[email protected]>
|
Found and fixed one small issue with this when working on Debian packages. |
|
That's quite a lot of changed. I didn't look too closely but nothing stood out as being obviously wrong. On Archlinux the linked libraries look good and everything still seems to work. |
|
Thanks for the check. |
rpavlik
added a commit
that referenced
this pull request
Jan 25, 2020
Patch release for the 1.0 series.
This release contains, among other things, a substantial simplification and
cleanup of the loader, which should fix a number of issues and also make it
forward compatible with extensions newer than the loader itself. As a part of
this change, the loader itself now only supports a single `XrInstance` active at
a time per process. If you attempt to create a new instance while an existing
one remains (such as in the case of application code leaking an `XrInstance`
handle), the loader will now return `XR_ERROR_LIMIT_REACHED`.
### GitHub Pull Requests
These had been integrated into the public repo incrementally.
- hello_xr
- Initialize hand_scale to 1.0
<#157>
- Fix Vulkan CHECK_CBSTATE build under newer MSVC
<#154>
- Initialize hand_scale to 1.0 to still show controller cubes even if
grabAction not available on startup.
<#157>
- Loader
- Single instance loader refactor with forward compatibility
<#146> (and internal
MRs 1599, 1621)
- Fix bug in loading API layers that could result in not loading an available
and enabled layer
<#155>
- Build
- Clean up linking, build loader and layers with all available
platform/presentation support, fix pkg-config file, rename `runtime_list`
test executable to `openxr_runtime_list`
<#149>
### Internal issues
- Registry
- Fix typo in visibility mesh enum comment.
- Add `XR_EXT_win32_appcontainer_compatible` extension.
- Scripts
- Fix comment typos.
- Sync scripts with Vulkan. (internal MR 1625)
- Loader
- Allow use of `/` in paths in FileSysUtils on Windows.
- Build
- Improve messages
- hello_xr
- Add D3D12 graphics plugin (internal MR 1616)
- Fix comment typo.
rpavlik
added a commit
to KhronosGroup/OpenXR-SDK
that referenced
this pull request
Jan 25, 2020
Patch release for the 1.0 series.
This release contains, among other things, a substantial simplification and
cleanup of the loader, which should fix a number of issues and also make it
forward compatible with extensions newer than the loader itself. As a part of
this change, the loader itself now only supports a single `XrInstance` active at
a time per process. If you attempt to create a new instance while an existing
one remains (such as in the case of application code leaking an `XrInstance`
handle), the loader will now return `XR_ERROR_LIMIT_REACHED`.
### GitHub Pull Requests
These had been integrated into the public repo incrementally.
- hello_xr
- Initialize hand_scale to 1.0
<KhronosGroup/OpenXR-SDK-Source#157>
- Fix Vulkan CHECK_CBSTATE build under newer MSVC
<KhronosGroup/OpenXR-SDK-Source#154>
- Initialize hand_scale to 1.0 to still show controller cubes even if
grabAction not available on startup.
<KhronosGroup/OpenXR-SDK-Source#157>
- Loader
- Single instance loader refactor with forward compatibility
<KhronosGroup/OpenXR-SDK-Source#146> (and internal
MRs 1599, 1621)
- Fix bug in loading API layers that could result in not loading an available
and enabled layer
<KhronosGroup/OpenXR-SDK-Source#155>
- Build
- Clean up linking, build loader and layers with all available
platform/presentation support, fix pkg-config file, rename `runtime_list`
test executable to `openxr_runtime_list`
<KhronosGroup/OpenXR-SDK-Source#149>
### Internal issues
- Registry
- Fix typo in visibility mesh enum comment.
- Add `XR_EXT_win32_appcontainer_compatible` extension.
- Scripts
- Fix comment typos.
- Sync scripts with Vulkan. (internal MR 1625)
- Loader
- Allow use of `/` in paths in FileSysUtils on Windows.
- Build
- Improve messages
- hello_xr
- Add D3D12 graphics plugin (internal MR 1616)
- Fix comment typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some patches mostly about linking - things that came up in the Debian packaging.
Only vaguely bikeshed patch is the one renaming the runtime_list tool again - this just renames the output file to be
openxr_runtime_listso that it can actually be installed (alaglxinfo,vkinfo)