-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reserve and vendor extension proposal for OPPO #144
Conversation
@rpavlik Could you help review this request? Let us know if there is anything we should update. Thanks a lot. |
Nope this looks fine to me, I'll just have to realign it when I go to merge to avoid conflicts. Did you want to reserve more than one or is one all you need? |
Thanks @rpavlik. One is good enough for foreseeable future. Thanks |
@rpavlik We added the actual proposal for XR_OPPO_controller_interaction on top of the original pull request to reserve placeholder ID. Could you help check again if there is something missing / wrong in the proposal? |
@rpavlik Sorry to bother you again. I'm wondering if we also need to create pull request to https://github.com/KhronosGroup/OpenXR-SDK/blob/main/include/openxr/openxr.h or that file would auto-generate changes related to this interaction profile extension? |
An issue (number 1955) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1955 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
** subpathname:/input/y/click | ||
** subpathname:/input/y/touch | ||
** subpathname:/input/menu/click | ||
** subpathname:/input/heartrate/value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heartrate
path needs to be decorated with heartrate_oppo
as per https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#_adding_input_sources_via_extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wallbraker Thanks for reviewing. I updated the path with _oppo decoration per your suggestion in a new commit in this pull request.
Feel free to let me know if there is anything else that needs to be updated.
Thanks
The headers auto-generate from the XML. I'll pull in the reservation first because there's a review process for the extensions. |
OK, I merged the reservation in #145 , please rebase on the |
Thanks @rpavlik for merge the reserve commit. If you or @Wallbraker could help review it again, it would be greatly appreciated. |
No description provided.