Advance notice of old-style grouping removals #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oddhack, if you're happy with this it's approved to merge. |
|
LGTM. |
|
@oddhack I had intended for the XX to be filled in with the day of merge (i.e. 07), could you edit the merged version as such? |
Done. |
|
Awesome, thanks!
…On Fri, 8 Jan 2021 at 10:07, Jon Leech ***@***.***> wrote:
@oddhack <https://github.com/oddhack> I had intended for the XX to be
filled in with the day of merge (i.e. 07), could you edit the merged
version as such?
Done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#442 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACVEYI4MXFBM24HPPIM5KULSY3KNHANCNFSM4TVSCG2Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's about time we start working to get #335 closed off. After a number of checkups in that thread, it seems that most users are happy for the old-style groupings to be removed, either having migrated to the new-style attributes or are in the process of doing so (maintaining a fork in the meantime)
The old-style groups have been deprecated for a long time now, so I've proposed a 3 month timeline between the date of merge and removal. The notice I have added to the README is akin to the one that was added to Vulkan a little while back.
I've enabled "Allow edits by maintainers" so the merger of this PR will be able to fill in the missing dates annotated with
XXby just editing the file on the PR.