-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cl_intel_bfloat16_conversions #762
cl_intel_bfloat16_conversions #762
Conversation
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: haonanya <[email protected]>
This backports #1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: haonanya <[email protected]>
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports #1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports #1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports KhronosGroup#1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
This backports #1406 OpenCL specification: KhronosGroup/OpenCL-Docs#762 SPIR-V: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc Signed-off-by: Haonan Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few typos.
Co-authored-by: Alastair Murray <[email protected]>
Thanks, that's embarassing. I'm not sure if my spell checker was too aggressive or not aggressive enough! I've accepted all three of the spelling fixes. |
Some comments that are not part of my review because they are technical comments on a shipping vendor extension, but leaving them here for posterity should this ever be considered more widely.
Not adding a new type is interesting as there is precedence for a storage-only floating-point type in OpenCL (
Yes, the paired numbers aren't great for reading, it requires both knowing the |
This PR adds the cl_intel_bfloat16_conversions specification that adds built-in functions to convert between 32-bit floating point values and bfloat16 values.
The related SPIR-V extension draft for bfloat16 conversions can be found here:
https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc
I will keep this as a draft PR and extension version 0.9.0 initially to allow for last minute changes before publication, but I believe the writeup is complete and I would appreciate any feedback. Thanks!