Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial unified SVM capability tests #2210

Merged

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Jan 5, 2025

These tests are passing on many devices using the unified SVM emulation layer.

Specifically, adds tests for:

  • CL_SVM_CAPABILITY_SINGLE_ADDRESS_SPACE_KHR
  • CL_SVM_CAPABILITY_DEVICE_UNASSOCIATED_KHR
  • CL_SVM_CAPABILITY_HOST_READ_KHR
  • CL_SVM_CAPABILITY_HOST_WRITE_KHR
  • CL_SVM_CAPABILITY_HOST_MAP_KHR
  • CL_SVM_CAPABILITY_DEVICE_READ_KHR
  • CL_SVM_CAPABILITY_DEVICE_WRITE_KHR
  • CL_SVM_CAPABILITY_DEVICE_ATOMIC_ACCESS_KHR
  • CL_SVM_CAPABILITY_INDIRECT_ACCESS_KHR

Still TODO:

  • CL_SVM_CAPABILITY_SYSTEM_ALLOCATED_KHR
  • CL_SVM_CAPABILITY_DEVICE_OWNED_KHR
  • CL_SVM_CAPABILITY_CONTEXT_ACCESS_KHR
  • CL_SVM_CAPABILITY_HOST_OWNED_KHR
  • CL_SVM_CAPABILITY_CONCURRENT_ACCESS_KHR
  • CL_SVM_CAPABILITY_CONCURRENT_ATOMIC_ACCESS_KHR

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@bashbaug
Copy link
Contributor Author

Merging (to the cl_khr_unified_svm branch), as discussed in the February 11th memory TSG.

@bashbaug bashbaug merged commit 1da0f4f into KhronosGroup:cl_khr_unified_svm Feb 11, 2025
9 checks passed
@bashbaug bashbaug deleted the initial-capability-testing branch February 11, 2025 19:42
bashbaug added a commit that referenced this pull request Feb 11, 2025
This PR includes tests for `clSVMAllocWithPropertiesKHR` and
`clGetSVMPointerInfoKHR` for valid pointers, as per the unified SVM test
plan. These tests are passing on many devices with the unified SVM
emulation layer.

Note, these tests use the same test fixture and unified SVM wrapper as
the unified SVM capability tests in #2210.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants