Vulkan timestamp query pools use Metal GPU counters when available. #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MVKPhysicalDeviceMetalFeatures::counterSamplingPoints to track platform availability of GPU counters. MVKPhysicalDevice creates and manages MTLCounterSets and checks for and enables flags within MVKPhysicalDeviceMetalFeatures::counterSamplingPoints. Add abstract MVKGPUCounterQueryPool class as parent of MVKTimestampQueryPool and MVKPipelineStatisticsQueryPool concrete classes and refactor access to host and command copy tracking data to allow extraction from MTLCounterSampleBuffer. MVKTimestampQueryPool uses MTLCounterSampleBuffer if supported, otherwise reverts to using host data for timestamps. MVKCommandEncoder encodes Vulkan timestamp commands either as Metal staged or command timestamps, depending on whether the GPU is tile-based or immediate-mode. For Metal stage counters, we use a light-weight dummy BLIT encoder to mark timestamp commands executed in the previous Metal encoding pass. Add MVKDevice::getDummyBlitMTLBuffer() to supply a dummy single-byte buffer that can be used by a stand-alone MTLBlitCommandEncoder as dummy work to mark timestamps.
|
@cdavis5e Please review if you can. Always good to have a second set of eyes on it...but if you are too busy to right now...let me know and I'll pull it in without the review. We can tweak later if needed. CTS tests pass. |
cdavis5e
requested changes
Jul 26, 2021
Remove dead code and make GPU counter creation error message generic.
cdavis5e
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKPhysicalDeviceMetalFeatures::counterSamplingPointsto track platform availability of GPU counters.MVKPhysicalDevicecreates and managesMTLCounterSetsand checks for and enables flags withinMVKPhysicalDeviceMetalFeatures::counterSamplingPoints.MVKGPUCounterQueryPoolclass as parent ofMVKTimestampQueryPoolandMVKPipelineStatisticsQueryPoolconcrete classes and refactor access to host and command copy tracking data to allow extraction fromMTLCounterSampleBuffer.MVKTimestampQueryPoolusesMTLCounterSampleBufferif supported, otherwise reverts to using host data for timestamps.MVKCommandEncoderencodes Vulkan timestamp commands either as Metal staged or command timestamps, depending on whether the GPU is tile-based or immediate-mode.MVKDevice::getDummyBlitMTLBuffer()to supply a dummy single-byte buffer that can be used by a stand-alone MTLBlitCommandEncoder as dummy work to mark timestamps.Fixes #773.
Fixes #793.
Fixes #520.