Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building of loadtest apps with locally installed dependencies #799

Merged
merged 33 commits into from
Nov 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f8ed876
Fix conflict between ktx.dll and ktx.exe PDB files.
MarkCallow Nov 5, 2023
c5b78b4
Support building with locally installed packages.
MarkCallow Nov 9, 2023
31a1b66
Build loadtests on arm64.
MarkCallow Nov 9, 2023
1220c93
Fix passing of CMAKE_TOOLCHAIN_FILE to build step.
MarkCallow Nov 9, 2023
ce4dd7b
Add required syntax.
MarkCallow Nov 9, 2023
0326d82
Fix many issues building with repo libs.
MarkCallow Nov 9, 2023
c549a1b
Add missing _LIBRARIES.
MarkCallow Nov 9, 2023
31678b2
Uncomment find_package commands.
MarkCallow Nov 10, 2023
cfcbde2
Only install vcpkg packages when building loadtests.
MarkCallow Nov 10, 2023
b03bcb8
Update vcpkg in an attempt to fix errors and cat log file to see fail…
MarkCallow Nov 10, 2023
28f8d90
Do not use SDL found on host when host != target.
MarkCallow Nov 10, 2023
73c8e5a
Fix the tests for host != target.
MarkCallow Nov 10, 2023
463eba5
Fix case mismatch in processor names.
MarkCallow Nov 10, 2023
2680ee6
Remove the vcpkg package update.
MarkCallow Nov 10, 2023
8b1e26a
Install sdl2, assimp only when ARCHS and processor match.
MarkCallow Nov 10, 2023
1a4d661
Fix typo.
MarkCallow Nov 10, 2023
3719f1e
Fix YAT.
MarkCallow Nov 10, 2023
aa4f58d
Explicitly add GLEW includes and libraries.
MarkCallow Nov 11, 2023
58eb7a9
GLEW...DIRS to GLEW...DIR.
MarkCallow Nov 11, 2023
2cebbca
Check in-use Win SDK and ls its libraries.
MarkCallow Nov 11, 2023
8b82111
Move in-use SDK check to build_win.ps1.
MarkCallow Nov 11, 2023
d4c0d4b
Only do in-use SDK version check when building loadtests.
MarkCallow Nov 11, 2023
e563a8f
Convert NSIS retry script to Bash.
MarkCallow Nov 11, 2023
91d734b
Add missing ".
MarkCallow Nov 11, 2023
de207a4
Attemp to override selected Windows SDK for oe with glu32.
MarkCallow Nov 11, 2023
743e92d
Improve logging of SDK info.
MarkCallow Nov 11, 2023
8e0eb0b
Don't use generator expression for GLEW_LIBS.
MarkCallow Nov 11, 2023
f5e5251
Turn off loadtests for arm64 build until lib issue resolved.
MarkCallow Nov 12, 2023
656846e
Fix test for whether loadtests is set.
MarkCallow Nov 12, 2023
77bd52f
Fix test properly this time.
MarkCallow Nov 12, 2023
1aad3be
Don't require OpenGL for iOS builds.
MarkCallow Nov 12, 2023
c2eab4d
Remove debug log messages and 2nd addition of glew.lib.
MarkCallow Nov 12, 2023
8a82392
Comment out printing of SDK version.
MarkCallow Nov 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ on:
# Also trigger on push of release tags to any branch. Useful
# for testing release builds before merging to main.
tags:
- 'v[0-9]+\.[0-9]+\.[0-9]+'
- 'v[0-9]+\.[0-9]+\.[0-9]+-*'
- 'v[0-9]+.[0-9]+.[0-9]+'
- 'v[0-9]+.[0-9]+.[0-9]+-*'
paths-ignore:
- .appveyor.yml
- .travis.yml
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mingw.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ on:
# Also trigger on push of release tags to any branch. Useful
# for testing release builds before merging to main.
tags:
- 'v[0-9]+\.[0-9]+\.[0-9]+'
- 'v[0-9]+\.[0-9]+\.[0-9]+-*'
- 'v[0-9]+.[0-9]+.[0-9]+'
- 'v[0-9]+.[0-9]+.[0-9]+-*'
paths-ignore:
- .appveyor.yml
- .travis.yml
Expand Down
40 changes: 34 additions & 6 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ on:
# Also trigger on push of release tags to any branch. Useful
# for testing release builds before merging to main.
tags:
- 'v[0-9]+\.[0-9]+\.[0-9]+'
- 'v[0-9]+\.[0-9]+\.[0-9]+-*'
- 'v[0-9]+.[0-9]+.[0-9]+'
- 'v[0-9]+.[0-9]+.[0-9]+-*'
paths-ignore:
- .appveyor.yml
- .travis.yml
Expand Down Expand Up @@ -65,7 +65,9 @@ jobs:
toolset: CLangCL
arch: arm64
# No tests on arm64 since the host is x64 and can't run the
# built tests
# built tests. loadtests is OFF because CMake insists on
# choosing an older Windows SDK which is missing glu32.lib.
# Can set to OpenGL once issue is resolved.
options: {
config: 'Debug,Release',
doc: ON, jni: ON, loadtests: OFF, tests: ON, tools: ON, tools_cts: ON,
Expand Down Expand Up @@ -120,9 +122,26 @@ jobs:
- name: Install NSIS with large string support
shell: bash
run: |
stack exec -- wget -O nsis-3.08-strlen_8192.zip https://downloads.sourceforge.net/nsis/NSIS%203/3.08/nsis-3.08-strlen_8192.zip
7z x -aoa -o"/c/Program Files (x86)/NSIS" nsis-3.08-strlen_8192.zip
rm nsis-3.08-strlen_8192.zip
retryCount=4
success=0
for i in $(seq $retryCount) ; do
echo "Attempt no: $i"
stack exec -- wget -O nsis-3.08-strlen_8192.zip https://downloads.sourceforge.net/nsis/NSIS%203/3.08/nsis-3.08-strlen_8192.zip
if [[ $? -eq 0 ]] ; then
success=1
7z x -aoa -o"/c/Program Files (x86)/NSIS" nsis-3.08-strlen_8192.zip
rm nsis-3.08-strlen_8192.zip
echo "Installation successful."
break
else
echo "Installation failed. Retrying..."
sleep $(( 2*$i ))
fi
done
if (( ! $success )) ; then
echo "Installation failed after $retryCount attempts."
exit 1
fi

- name: Force fetch provoking tag's annotation.
# Work around https://github.com/actions/checkout/issues/290.
Expand Down Expand Up @@ -164,6 +183,15 @@ jobs:
echo "CODE_SIGN_KEY_VAULT=Azure" >> $env:GITHUB_ENV
}

- name: Install Dependencies for load tests on arm64
if: matrix.arch == 'arm64' && matrix.options.loadtests != 'OFF'
run: |
pushd $env:VCPKG_INSTALLATION_ROOT
./vcpkg install SDL2:arm64-windows assimp:arm64-windows glew:arm64-windows
cat buildtrees\glew\install-arm64-windows-rel-out.log
popd
echo "CMAKE_TOOLCHAIN_FILE=$env:VCPKG_INSTALLATION_ROOT/scripts/buildsystems/vcpkg.cmake" >> $env:GITHUB_ENV

- name: Install Dependencies
# This script only installs what's needed by ON FEATUREs.
run: ci_scripts/install_win.ps1
Expand Down
7 changes: 6 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ addons:
packages:
- git-lfs
- doxygen
- sdl2
#update: true

env:
Expand Down Expand Up @@ -217,6 +216,12 @@ install:
fi
;;
osx)
if [ "$PLATFORM" = "macOS" -a "$ARCHS" = $(uname -m) ]; then
# We're building for the host processor type. Safe to use
# brew installed libraries instead of repo included ones.
brew install sdl2
brew install assimp
fi
./ci_scripts/install_macos.sh
;;
esac
Expand Down
12 changes: 12 additions & 0 deletions ci_scripts/build_win.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,18 @@ if(!$?){
exit 1
}

# Find SDK version and ls it
#if ($FEATURE_LOADTESTS -ne "OFF") {
# $m = select-string -Pattern "<WindowsTargetPlatformVersion>(?<version>(?<major>[0-9][0-9])[0-9\.]*)</.*" -Path $BUILD_DIR/tests/loadtests/gl3loadtests.vcxproj
# $sdk_ver = $m.matches[0].groups["version"].value
# $sdk_major = $m.matches[0].groups["major"].value
# echo "sdk_ver = $sdk_ver"
# echo "sdk_major = $sdk_major"
# ls "C:\Program Files (x86)\Windows Kits\$sdk_major\lib"
# ls "C:\Program Files (x86)\Windows Kits\$sdk_major\lib\$sdk_ver\um\arm64\glu32.lib" -ErrorAction 'Continue'
# ls "C:\Program Files (x86)\Windows Kits\$sdk_major\lib\$sdk_ver\um\x64\glu32.lib" -ErrorAction 'Continue'
#}

$configArray = $CONFIGURATION.split(",")
foreach ($config in $configArray) {
pushd $BUILD_DIR
Expand Down
Loading