Fix normalization when the result overflows #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using uint for max values now because uint Max32 can't be represented in IEEE754 single precision float. In calculations it will be promoted to float. Changed normalization function for single channel images to return max of the data type assuming (x, 0, 0, 0) vectors. And changed the test values accordingly
|
@MarkCallow Have a look at this fix and let me know what you think. |
|
Thanks @wasimabbas-arm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using uint for max values now because uint Max32 can't be represented in IEEE754 single precision float. In calculations it will be promoted to float. Changed normalization function for single channel images to return max of the data type assuming (x, 0, 0, 0) vectors. And changed the test values accordingly