Fixing support for mingw toolchains that target the newer ucrt #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
reviewed
Oct 22, 2022
lib/filestream.c
Outdated
| // Need to flush so that fstat will return the current size. | ||
| // Can ignore return value. The only error that can happen is to tell you | ||
| // it was a NOP because the file is read only. | ||
| #if (defined(_MSC_VER) && _MSC_VER < 1900) || defined(__MINGW32__) && !defined(_UCRT) |
There was a problem hiding this comment.
Should we change __MINGW32__ to __MINGW64__?
There was a problem hiding this comment.
Oh yeah I forgot to reply to that part of the issue. I don't think we really need to. It'll work the same either way but I can change it if you think it's a good idea.
There was a problem hiding this comment.
Please change it to __MINGW64__. Since KTX-Software only supports 64-bit builds, it will be less confusing.
There was a problem hiding this comment.
That was quick! Thanks.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix: #641